Add test role for converting external Swift storage nodes - #1356
Conversation
Swift adoption is a two-stage process:
- Stage 1 (role swift_adoption) adopts the control plane and ring
configuration. The Swift proxy service will run on OpenShift
afterwards, Swift storage services will remain on the former nodes
(either control plane or external storage nodes).
- Stage 2 differs based on the goal:
- either migrate data (eg. from control planes to PVs or dataplane
nodes) using the existing role (swift_migration)
- or convert existing nodes in place (eg. external ObjectStorage
nodes) using the new role (swift_conversion).
This commit adds the test role for the conversion. This is basically a
Swift storage dataplane deployment using pre-provisioned nodes,
disabling the former TripleO services.
After running the initial control plane adoption, delete the existing
OpenStackDataPlaneNodeSet before starting the conversion test. For
example:
make test-minimal
oc delete --ignore-not-found=true OpenStackDataPlaneNodeSet --all
make test-swift-conversion
JIRA: OSPRH-28625
Signed-off-by: Christian Schwede <cschwede@redhat.com>
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/19041c3c5f5b44479285ccdd23187b2e ✔️ noop SUCCESS in 0s |
| edpm_node_hostname: edpm-swift-0 | ||
| edpm_user: root | ||
|
|
||
| edpm_bootstrap_command: | |
There was a problem hiding this comment.
I'm not sure if all these general variables should be defaulted inside the role, but given that this role is used in isolation (its own playbook and make target), it's probably ok.
There was a problem hiding this comment.
Yes, I agree, and I was a bit hesitant as well. At the end I basically used the same approach as the dataplane_adoption role, and as you wrote this runs in isolation - that worked fine during my tests.
|
recheck Failed test should be unrelated to this change. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jistr The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cafc332
into
openstack-k8s-operators:main
Swift adoption is a two-stage process:
Stage 1 (role swift_adoption) adopts the control plane and ring configuration. The Swift proxy service will run on OpenShift afterwards, Swift storage services will remain on the former nodes (either control plane or external storage nodes).
Stage 2 differs based on the goal:
This commit adds the test role for the conversion. This is basically a Swift storage dataplane deployment using pre-provisioned nodes, disabling the former TripleO services.
After running the initial control plane adoption, delete the existing OpenStackDataPlaneNodeSet before starting the conversion test. For example:
make test-minimal
oc delete --ignore-not-found=true OpenStackDataPlaneNodeSet --all make test-swift-conversion
JIRA: OSPRH-28625